Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG: fix incorrectly formatted raise statement #911

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

BUG: fix incorrectly formatted raise statement #911

wants to merge 2 commits into from

Conversation

mj-will
Copy link
Collaborator

@mj-will mj-will commented Feb 10, 2025

The raise statement in get_all_injection_credible_levels is incorrectly formatted. This PR fixes the formatting.

This wasn't being caught by the existing test, since the error was also a TypeError:

TypeError: exceptions must derive from BaseException

so I've also updated the test to check error message itself.

@mj-will mj-will added the bug Something isn't working label Feb 10, 2025
ColmTalbot
ColmTalbot approved these changes Feb 19, 2025
View reviewed changes
Copy link
Collaborator

@ColmTalbot ColmTalbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch on the test failure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adivijaykumar adivijaykumar adivijaykumar approved these changes

@ColmTalbot ColmTalbot ColmTalbot approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mj-will @adivijaykumar @ColmTalbot